Minor: Update LogicalPlan::join_on API, use it more #7814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
jackwener
approved these changes
Oct 13, 2023
Contributor
Author
|
Thank you for the review @jackwener 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #7766, follow on to #7805
Rationale for this change
@jackwener suggested in https://github.com/apache/arrow-datafusion/pull/7805/files#r1356685435 that the newly added
LogicalPlan::join_onAPI could be used more widely:What changes are included in this PR?
join_onmore widely.DataFrame::join_onand take an iterator of Exprs rather than just an Expr.Are these changes tested?
Covered by existing tests
Are there any user-facing changes?
Since the API change in #7805 has not been released, this is not a end-user visible API change