feat(7849): coerce TIMESTAMP to TIMESTAMPTZ #7850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add coercion rules to support coercion from timestamp types without a timezone to a timestamp with a timezone. Like with the coercion of strings or numeric constants, when a function requires the TIMEZONE_WILDCARD placeholder timezone "+00" will be used as the timezone offset.
github-actions
bot
added
logical-expr
alamb
approved these changes
Oct 18, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
This makes sense to me -- thank you @mhilton
I suggest we also add a cast for a comparison, it is isn't there already, as I believe the code changed in this PR is only used for coercing function arguments. Something like this, perhaps:
select TIMESTAMPTZ '2022-01-01 20:10:00Z' = TIMESTAMP '2020-01-01')
jackwener
approved these changes
Oct 18, 2023
Add additional SQL logic test suggested in review.
crepererum
reviewed
Oct 18, 2023
Add a positive test case for TIMESTAMPTZ and TIMESTAMP comparison.
Contributor
|
Thanks again everyone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7849.
Rationale for this change
Currently operations that one might reasonable expect to succeed using date_bin and mixing TIMESTAMP and TIMESTAMPTZ types error because the type coercion cannot coerce to a supported set of parameters.
What changes are included in this PR?
Add coercion rules to support coercion from timestamp types without a timezone to a timestamp with a timezone. Like with the coercion of strings or numeric constants, when a function requires the TIMEZONE_WILDCARD placeholder timezone "+00" will be used as the timezone offset.
Are these changes tested?
Yes, I have added an sqllogictest for the exact case I would like to see supported.
Are there any user-facing changes?
No