Add multi-column topk fuzz tests #7898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dandandan
approved these changes
Oct 22, 2023
Contributor
Author
|
Thank you @Dandandan |
alamb
commented
Oct 22, 2023
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn test_sort_topk_i64str() { |
Contributor
Author
There was a problem hiding this comment.
This is the multi-column fuzz test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This is a follow on to #7772 (❤️ ) by @Tangruilin
Rationale for this change
I would like coverage for multi-column sorts as well as coverage for different limit values as well
What changes are included in this PR?
limit_fuzz.rsas they are independent of the Sort fuzz testsAre these changes tested?
Only tests
Are there any user-facing changes?
no