Skip to content

Conversation

@PsiACE
Copy link
Member

@PsiACE PsiACE commented Nov 16, 2023

Which issue does this PR close?

Closes #8215.

Rationale for this change

Part of #6195.

What changes are included in this PR?

Deleted subqueries.rs and added test cases in subquery.slt.

Are these changes tested?

I followed the conversion rules, but this test itself is a test marked as ignored, and I still ignored it by commenting.

Are there any user-facing changes?

No

Signed-off-by: Chojan Shang <psiace@apache.org>
@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Nov 16, 2023
Signed-off-by: Chojan Shang <psiace@apache.org>
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @PsiACE

@alamb alamb merged commit b126bca into apache:main Nov 16, 2023
@PsiACE PsiACE deleted the subquery-slt branch November 16, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port tests in subqueries.rs to sqllogictest

2 participants