Skip to content

Replace macro in array_array to remove duplicate codes #8252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alamb merged 1 commit into from
Nov 17, 2023
Merged

Replace macro in array_array to remove duplicate codes #8252

alamb merged 1 commit into from
Nov 17, 2023

Conversation

@Veeupup
Copy link
Contributor

@Veeupup Veeupup commented Nov 17, 2023 •
edited
Loading

Which issue does this PR close?

Closes #.

fix array_array in #7988

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the physical-expr Changes to the physical-expr crates label Nov 17, 2023
@Veeupup Veeupup changed the title replace macro in array_array Replace macro in array_array to remove duplicate codes Nov 17, 2023
@Veeupup Veeupup marked this pull request as ready for review November 17, 2023 15:35
@Veeupup
Copy link
Contributor Author

Veeupup commented Nov 17, 2023

@alamb @jayzhan211 this PR is ready for review.

PTAL : )

@Veeupup
Replace macro in array_array to remove duplicate codes
6349684 
Signed-off-by: veeupup <code@tanweime.com>
comphead
comphead reviewed Nov 17, 2023
View reviewed changes
comphead
comphead approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Veeupup for making the code cleaner.
Please address a minor nit

Weijun-H
Weijun-H approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@Weijun-H Weijun-H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! I have been tired of using macros in arrays for a long time. Thank you, @Veeupup 👍

alamb
alamb approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Veeupup and all reviewers. This code is 🚀

@alamb alamb merged commit db92d4e into apache:main Nov 17, 2023
@jayzhan211 jayzhan211 mentioned this pull request Nov 18, 2023
Closed
@Veeupup Veeupup deleted the array_array branch November 21, 2023 15:06
@matthewgapp matthewgapp mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

@comphead comphead comphead approved these changes

@Weijun-H Weijun-H Weijun-H approved these changes

Assignees

No one assigned

Labels

physical-expr Changes to the physical-expr crates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Veeupup @alamb @comphead @Weijun-H