Rename expr::window_function::WindowFunction to WindowFunctionDefinition, make structure consistent with ScalarFunction
#8382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
haohuaijin
reviewed
Dec 1, 2023
alamb
reviewed
Dec 1, 2023
datafusion/expr/src/expr.rs
Outdated
| /// | ||
| /// [window function]: https://en.wikipedia.org/wiki/Window_function_(SQL) | ||
| #[derive(Debug, Clone, PartialEq, Eq, Hash, EnumIter)] | ||
| pub enum BuiltInWindowFunction { |
Contributor
There was a problem hiding this comment.
Maybe you could put BuiltInWindowFunction in datafusion/expr/src/built_in_window_function.rs to mirror BuiltInFunction?
https://github.com/apache/arrow-datafusion/blob/main/datafusion/expr/src/built_in_function.rs
Contributor
Author
There was a problem hiding this comment.
@alamb @haohuaijin have I understood correctly?
BuiltinWindowFunctiongoes intodatafusion/expr/src/built_in_window_function.rsWindowFunctionbecomesWindowFunctionDefinitionand goes intodatafusion/expr/src/expr.rswith its trait implementations- public functions in
window_functionstays there
Contributor
There was a problem hiding this comment.
BuiltinWindowFunctiongoes intodatafusion/expr/src/built_in_window_function.rsWindowFunctionbecomesWindowFunctionDefinitionand goes intodatafusion/expr/src/expr.rswith its trait implementations
yes, you are correct.
- public functions in
window_functionstays there
maybe those public functions also can move to datafusion/expr/src/built_in_window_function.rs. cc @alamb
8 tasks
Contributor
|
This PR looks like it needs some work so marking it as a draft until it is ready for review again |
alamb
changed the title
expr::window_function::WindowFunction to WindowFunctionDefinition, make structure consistent with ScalarFunction
alamb
approved these changes
Dec 23, 2023
| @@ -0,0 +1,207 @@ | |||
| // Licensed to the Apache Software Foundation (ASF) under one | |||
7 tasks
Contributor
|
Thanks again @edmondop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8347
Rationale for this change
The idea is to have the ScalarFunctions and WindowFunctions consistent in structure with each other
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?