feat: ScalarValue from String

[QuenKar]

Which issue does this PR close?

Closes #8380 .

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

[Weijun-H]

LGTM! Thanks @QuenKar

[jackwener]

Is there anywhere else the code could use this change？ if so I think it could be changed together.

[viirya]

Hmm, as we already implement From<&str> for ScalarValue, we can simply do this for a String if we want to have a ScalarValue for it:

let scalar = ScalarValue::from("foo".to_string().as_str());
assert_eq!(scalar, ScalarValue::Utf8(Some("foo".to_string())));

I think the only difference is From<String> avoids copying the string content?

Do we have used as_str() for String in current code to create ScalarValue? We probably can change to remove as_str().

[QuenKar]

I find that there is no code similar to "foo".to_string().as_str() or some_string.as_str() or &some_string or as_str().into() in this use(But maybe I don't find all of them...

[Dandandan]

One tricky might be removing From<&str> implementqtion and seeing if something fails to compile.

[alamb]

I think the only difference is From avoids copying the string content?

It avoids copying as well as makes creating ScalarValues easier to create / user (e.g. someone was confused as reported on #8380)

One tricky might be removing From<&str> implementqtion and seeing if something fails to compile.

I tried this and found there weren't any obvious examples in the codebase -- the more common pattern is ScalarValue::from("foo") with a constant string

[viirya]

I tried this and found there weren't any obvious examples in the codebase -- the more common pattern is ScalarValue::from("foo") with a constant string

Nice!

[alamb]

Thank you @QuenKar and @Dandandan and @viirya

[alamb]

I think the only difference is From avoids copying the string content?

It avoids copying as well as makes creating ScalarValues easier to create / user (e.g. someone was confused as reported on #8380)

One tricky might be removing From<&str> implementqtion and seeing if something fails to compile.

I tried this and found there weren't any obvious examples in the codebase -- the more common pattern is ScalarValue::from("foo") with a constant string