Skip to content

Conversation

@Weijun-H
Copy link
Member

@Weijun-H Weijun-H commented Dec 5, 2023

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the physical-expr Changes to the physical-expr crates label Dec 5, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Weijun-H -- this is a nice improvement 👍 I have a suggestion to make things even simpler, but I think this PR could be merged as is too

@Weijun-H Weijun-H changed the title Minor: convert marcro list-slice to function Minor: convert marcro list-slice and slice to function Dec 5, 2023
@alamb
Copy link
Contributor

alamb commented Dec 6, 2023

Thanks again @Weijun-H

@alamb alamb merged commit 4a46f31 into apache:main Dec 6, 2023
appletreeisyellow pushed a commit to appletreeisyellow/datafusion that referenced this pull request Dec 15, 2023
* remove marcro list-slice

* fix cast dyn Array

* remove macro slice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-expr Changes to the physical-expr crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants