Skip to content

Implement contained API in PruningPredicate #8440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 7 commits into from
Dec 23, 2023
Merged

Implement contained API in PruningPredicate #8440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
66e212c
Implement `contains` API in PruningPredicate
alamb Dec 6, 2023
c37ff9e
Merge remote-tracking branch 'apache/main' into alamb/contains_api
alamb Dec 20, 2023
324cb10
Apply suggestions from code review
alamb Dec 20, 2023
537bd07
Merge branch 'alamb/contains_api' of github.com:alamb/arrow-datafusio…
alamb Dec 20, 2023
3775f0f
Add comment to len(), fix fmt
alamb Dec 20, 2023
71c41f2
rename BoolVecBuilder::append* to BoolVecBuilder::combine*
alamb Dec 22, 2023
3552f8d
Merge remote-tracking branch 'apache/main' into alamb/contains_api
alamb Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion datafusion/core/src/datasource/physical_plan/parquet/page_filter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ use arrow::array::{
};
use arrow::datatypes::DataType;
use arrow::{array::ArrayRef, datatypes::SchemaRef, error::ArrowError};
use datafusion_common::{DataFusionError, Result};
use datafusion_common::{DataFusionError, Result, ScalarValue};
use datafusion_physical_expr::expressions::Column;
use datafusion_physical_expr::{split_conjunction, PhysicalExpr};
use log::{debug, trace};
Expand All @@ -37,6 +37,7 @@ use parquet::{
},
format::PageLocation,
};
use std::collections::HashSet;
use std::sync::Arc;

use crate::datasource::physical_plan::parquet::parquet_to_arrow_decimal_type;
Expand Down Expand Up @@ -554,4 +555,12 @@ impl<'a> PruningStatistics for PagesPruningStatistics<'a> {
))),
}
}

fn contained(
&self,
_column: &datafusion_common::Column,
_values: &HashSet<ScalarValue>,
) -> Option<BooleanArray> {
None
}
}
9 changes: 9 additions & 0 deletions datafusion/core/src/datasource/physical_plan/parquet/row_groups.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
// under the License.

use arrow::{array::ArrayRef, datatypes::Schema};
use arrow_array::BooleanArray;
use arrow_schema::FieldRef;
use datafusion_common::tree_node::{TreeNode, VisitRecursion};
use datafusion_common::{Column, DataFusionError, Result, ScalarValue};
Expand Down Expand Up @@ -340,6 +341,14 @@ impl<'a> PruningStatistics for RowGroupPruningStatistics<'a> {
let scalar = ScalarValue::UInt64(Some(c.statistics()?.null_count()));
scalar.to_array().ok()
}

fn contained(
&self,
_column: &Column,
_values: &HashSet<ScalarValue>,
) -> Option<BooleanArray> {
None
}
}

#[cfg(test)]
Expand Down
Loading