Minor: make SubqueryAlias::try_new take Arc<LogicalPlan> #8542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, all `#[non_exhaustive]` logical plan structs with a `try_new` constructor take `Arc<LogicalPlan>` as parameter, except for `SubqueryAlias`, which takes a `LogicalPlan`. This changes `SubqueryAlias::try_new` to align with the other plan types, to improve API ergonomics.
Dandandan
added
wontfix
api change
Dandandan
approved these changes
Dec 14, 2023
alamb
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Currently, all
#[non_exhaustive]logical plan structs with atry_newconstructor takeArc<LogicalPlan>as parameter, except forSubqueryAlias, which takes aLogicalPlan. This change makesSubqueryAlias::try_newuniform with the other plan type constructors, to improve API ergonomics.What changes are included in this PR?
SubqueryAlias::try_newto takeArc<LogicalPlan>instead ofLogicalPlan.Are these changes tested?
Yes.
Are there any user-facing changes?
No.