feat: support LargeList in cardinality
#8726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
jayzhan211
reviewed
Jan 3, 2024
| .collect::<Result<UInt64Array>>()?; | ||
|
|
||
| let result = match &args[0].data_type() { | ||
| DataType::List(_) => { |
Contributor
There was a problem hiding this comment.
Although this implementation is small, I think having a closure for generic array is still a good practice.
Contributor
There was a problem hiding this comment.
I agree it would be better to avoid the duplication if possible
comphead
reviewed
Jan 4, 2024
| let list_array = as_large_list_array(&args[0])?; | ||
| generic_list_cardinality::<i64>(list_array) | ||
| } | ||
| _ => { |
Contributor
There was a problem hiding this comment.
Suggested change
| _ => { | |
| other => { | |
| exec_err!( | |
| "cardinality does not support type '{:?}'", | |
| other | |
| ) | |
| } |
9 tasks
comphead
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Parts #8185
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?