Skip to content

Minor: Use faster check for column name in schema merge #8765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 1 commit into from
Jan 5, 2024
Merged

Minor: Use faster check for column name in schema merge #8765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions datafusion/common/src/dfschema.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,9 +230,9 @@ impl DFSchema {
for field in other_schema.fields() {
// skip duplicate columns
let duplicated_field = match field.qualifier() {
Some(q) => self.field_with_name(Some(q), field.name()).is_ok(),
Some(q) => self.has_column_with_qualified_name(q, field.name()),
// for unqualified columns, check as unqualified name
None => self.field_with_unqualified_name(field.name()).is_ok(),
None => self.has_column_with_unqualified_name(field.name()),
};
if !duplicated_field {
self.fields.push(field.clone());
Expand Down