[task #8203] Port tests in joins.rs to sqllogictest #8996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
9 tasks
Signed-off-by: tangruilin <tang.ruilin@foxmail.com>
alamb
approved these changes
Jan 25, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks great @Tangruilin -- thank you very much 🙏
| use super::*; | ||
|
|
||
| #[tokio::test] | ||
| #[ignore] |
alamb
reviewed
Jan 25, 2024
| Ok(ctx) | ||
| } | ||
|
|
||
| async fn register_aggregate_csv_by_sql(ctx: &SessionContext) { |
Contributor
There was a problem hiding this comment.
I agree with the assesment that these tests shouldn't be moved: #8203 (comment)
The other tests assert the phyical plan, so I do not move them to joins.slt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8203.
Rationale for this change
What changes are included in this PR?
Move the tests in
joins.rstojoins.sltAre these changes tested?
YES
Are there any user-facing changes?