Update minimum rust version to 1.72 by alamb · Pull Request #8997 · apache/datafusion

alamb · 2024-01-25T13:04:13Z

Which issue does this PR close?

NOTE: Update to update to MSRV 1.72 (was 1.71)

Rationale for this change

the new version of env_logger requires rust 1.71: Update env_logger requirement from 0.10 to 0.11 #8944
Current MSRV of 1.70 which was released more than 6 months ago: https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1700-2023-06-01 (ages in Rust time)

MSRV 1.72 is still 5 months ago: in 2023-08-24 https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1720-2023-08-24

Most recent rust is 1.75: released end of Dec 2023
https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1750-2023-12-28

What changes are included in this PR?

Update Minimum rust version to 1.72

Are these changes tested?

Covered by existing tests

Are there any user-facing changes?

Jefffrey · 2024-01-27T21:48:33Z

 license = { workspace = true }
 authors = { workspace = true }
-rust-version = "1.70"
+rust-version = "1.71"


Could we take this opportunity to set this as same as workspace? e.g.

https://github.com/apache/arrow-datafusion/blob/7a5f2054305fd92852b589473afbc9bb034379d7/datafusion/physical-plan/Cargo.toml#L29

Unless its preferable to keep these separate? (even though they currently are the same)

That is an excellent idea. I vaguely (but perhaps incorrectly) remember something related to releasing was tricky with MSRV -- @andygrove do you remember? Would it be ok to switch the sub crates to use the workspace version?

Done in 9280b7a

Ok, I found out again. The reason the version is replicated is that cargo msrv verify doesn't support workspace versions

Thus if you do cd datafusion/core && cargo msrv verify, it fails like

Fetching index Unable to find key 'package.rust-version' (or 'package.metadata.msrv') in '/Users/andrewlamb/Software/arrow-datafusion/Cargo.toml'

I have fixed that

Tracking issue for that in cargo msrv: foresterre/cargo-msrv#590

Thanks @Jefffrey -- I have added an issue ref as a comment so we don't forget it in the future

ozankabak · 2024-01-31T10:42:19Z

Should we upgrade to 1.75 to avoid two upgrades? The latest version of one of our dependencies, ahash, requires 1.75 and we will hit problems sooner or later

alamb · 2024-01-31T11:38:54Z

Should we upgrade to 1.75 to avoid two upgrades? The latest version of one of our dependencies, ahash, requires 1.75 and we will hit problems sooner or later

Going up to the latest stable would be good from my perspective.

I think we should decide what our policy is and document it. @comphead 's recent change #9071 documents what the test is but not what the policy is (aka when we will update the value).

@Ted-Jiang also filed #8743

Here is my proposal -- I'll a "MSRV policy" ticket with proposal, and we can have a larger community discussion around that.

alamb · 2024-01-31T12:00:19Z

Ok, after some more consideration, I propose we change this PR to update to 1.72 to close @Ted-Jiang's #8743 and hopefully unblock ahash updates, and then we have the larger discussion about MSRV policy with the wider community via #9082

alamb · 2024-01-31T12:37:23Z

-        let mut hasher = SEED.build_hasher();
-        other.hash(&mut hasher);
-        let o = hasher.finish();
+        let s = SEED.hash_one(self);


Clippy failed on this for me with the updated MSRV so I did what it told me

comphead

lgtm thanks @alamb let me know if we need a review for MSRV policy or dscussion

alamb · 2024-01-31T16:09:19Z

lgtm thanks @alamb let me know if we need a review for MSRV policy or dscussion

Thanks @comphead -- let's have the MSRV policy discussion on #9082

Jefffrey

👍

Omega359 · 2024-02-05T14:09:56Z

@alamb You missed the cli Dockerfile unfortunately - it's still 1.70 and won't build without bumping up the version.

alamb · 2024-02-05T16:28:00Z

@alamb You missed the cli Dockerfile unfortunately - it's still 1.70 and won't build without bumping up the version.

Will fix.

Update: #9135

Update minimum rust version to 1.71

fc40314

github-actions Bot added documentation Improvements or additions to documentation core Core DataFusion crate substrait Changes to the substrait crate labels Jan 25, 2024

alamb mentioned this pull request Jan 25, 2024

Update env_logger requirement from 0.10 to 0.11 #8944

Merged

Fix clippy lint about hasher

c6f8d16

github-actions Bot added logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates labels Jan 25, 2024

Jefffrey reviewed Jan 27, 2024

View reviewed changes

alamb added 2 commits January 29, 2024 17:25

Merge remote-tracking branch 'apache/main' into alamb/update_msrv

fd3d99d

Use workspace MSRV

9280b7a

This was referenced Jan 30, 2024

doc: update Rust version compatibility #9062

Closed

Document minimum required rust version #9071

Merged

alamb mentioned this pull request Jan 31, 2024

[DISCUSSION] Define a MSRV (Minimum Supported Rust Version) policy #9082

Closed

alamb added 2 commits January 31, 2024 07:26

Merge remote-tracking branch 'apache/main' into alamb/update_msrv

32b1793

Update to 1.72 and fix checks

e9ec766

alamb changed the title ~~Update minimum rust version to 1.71~~ Update minimum rust version to 1.72 Jan 31, 2024

alamb commented Jan 31, 2024

View reviewed changes

fix substrait

681bb5b

comphead approved these changes Jan 31, 2024

View reviewed changes

Jefffrey approved these changes Jan 31, 2024

View reviewed changes

alamb commented Jan 31, 2024

View reviewed changes

Comment thread datafusion/core/Cargo.toml

Update datafusion/core/Cargo.toml

e7b6739

comphead merged commit 1f70823 into apache:main Feb 1, 2024

alamb deleted the alamb/update_msrv branch February 1, 2024 16:37

alamb mentioned this pull request Feb 5, 2024

Fix Dockerfile min rust version to 1.72 #9135

Merged

Jefffrey mentioned this pull request Feb 13, 2024

Fix rust-version key in workspace Cargo.toml to inherit from workspace #9214

Closed

Conversation

alamb commented Jan 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

Jefffrey Jan 27, 2024

Choose a reason for hiding this comment

Uh oh!

alamb Jan 28, 2024

Choose a reason for hiding this comment

Uh oh!

alamb Jan 29, 2024

Choose a reason for hiding this comment

Uh oh!

alamb Jan 31, 2024

Choose a reason for hiding this comment

Uh oh!

Jefffrey Jan 31, 2024

Choose a reason for hiding this comment

Uh oh!

alamb Jan 31, 2024

Choose a reason for hiding this comment

Uh oh!

ozankabak commented Jan 31, 2024

Uh oh!

alamb commented Jan 31, 2024

Uh oh!

alamb commented Jan 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alamb Jan 31, 2024

Choose a reason for hiding this comment

Uh oh!

comphead left a comment

Choose a reason for hiding this comment

Uh oh!

alamb commented Jan 31, 2024

Uh oh!

Jefffrey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Omega359 commented Feb 5, 2024

Uh oh!

alamb commented Feb 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

alamb commented Jan 25, 2024 •

edited

Loading

alamb commented Jan 31, 2024 •

edited

Loading

alamb commented Feb 5, 2024 •

edited

Loading