Add metrics for SortExect + HashAggregateExec #938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Aug 24, 2021
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn explain_analyze_baseline_metrics() { |
Contributor
Author
There was a problem hiding this comment.
Here is the basic testing strategy I plan for these baseline metrics
alamb
force-pushed
the
alamb/annotate_group_and_sort
branch
from
d273884 to
1ea391c
Compare
alamb
changed the title
alamb
force-pushed
the
alamb/annotate_group_and_sort
branch
from
ead2a53 to
9471210
Compare
alamb
force-pushed
the
alamb/annotate_group_and_sort
branch
from
409bb83 to
c7eeb5d
Compare
houqp
approved these changes
Aug 28, 2021
H0TB0X420
pushed a commit
to H0TB0X420/datafusion
that referenced
this pull request
Oct 7, 2025
…pache#938) * feat: add `empty` function as alias of array_empty * fix: correct typo in null_treatment parameter documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Next part #866
Rationale for this change
We want basic understanding of where a plan's time is spent and in what operators. See #866 for more details
What changes are included in this PR?
SortExecandHashAggregateExecusing the API from Add BaselineMetrics, Timestamp metrics, add forCoalescePartitionsExec, rename output_time -> elapsed_compute #909Are there any user-facing changes?
More fields in
EXPLAIN ANALYZEare now filled out