test: sqllogictests for multiple tables join #9480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korowa
force-pushed
the
multiple_tables_join_tests
branch
from
748ff58 to
447b2d0
Compare
Contributor
|
what is the difference between join.slt and joins.slt |
jayzhan211
approved these changes
Mar 9, 2024
Contributor
I am not sure -- it would be nice to consolidate them (or make it clearer when to put tests where) |
Contributor
|
Thanks @korowa and @jayzhan211 for the review |
Contributor
Author
According to history the first one is the "original" sqllogictests for joins, and the second one is the result of porting integration tests to sqllogictests format, so consolidation may be reasonable in this case indeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6744.
Rationale for this change
The fix for the issue itself was introduced in #7529, this PR just adds more high-level tests to ensure that further optimizer/physical plan changes won't cause this regression, as DF seems to lack this kind of tests (at least I wasn't able to found multi-table join tests, except for couple of them in
joins.slt)What changes are included in this PR?
Multi-table join tests added to
join.sltAre these changes tested?
Are there any user-facing changes?
No