Port ArrayExcept to functions-array subcrate
#9634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
43 tasks
jayzhan211
reviewed
Mar 16, 2024
| } | ||
|
|
||
| fn return_type(&self, arg_types: &[DataType]) -> datafusion_common::Result<DataType> { | ||
| match &arg_types[0] { |
Contributor
There was a problem hiding this comment.
The return type is mismatched with the previous one, and it is much more complex, any reason for this change?
Member
Author
There was a problem hiding this comment.
@jayzhan211 Thanks for review. You' re right so we can sync with previous return_type
jayzhan211
approved these changes
Mar 18, 2024
Contributor
jayzhan211
left a comment
jayzhan211
left a comment
There was a problem hiding this comment.
Thanks @erenavsarogullari
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9633.
What changes are included in this PR?
This PR aims to do following changes in terms of Epic #9285:
ArrayExcept are ported to functions-array subcrate.
Are these changes tested?
Yes, all
array.sltbased ArrayExcept tests are passed.Are there any user-facing changes?
No