Use stabalized aws-sdk and clap versions in datafusion-cli#9659
Closed
satyakommula96 wants to merge 3 commits intoapache:mainfrom
Closed
Use stabalized aws-sdk and clap versions in datafusion-cli#9659satyakommula96 wants to merge 3 commits intoapache:mainfrom
datafusion-cli#9659satyakommula96 wants to merge 3 commits intoapache:mainfrom
Conversation
Author
datafusion-cli
alamb
previously approved these changes
Mar 18, 2024
Contributor
alamb
left a comment
There was a problem hiding this comment.
Thank you @satyakommula96 -- I also merged up from main to fix a conflict in this PR and to trigger the CI.
Contributor
|
🤔 CI seems to have failed here: https://github.com/apache/arrow-datafusion/actions/runs/8327813127/job/22786403043?pr=9659 |
Contributor
|
ouch, MSRV failed. https://github.com/smithy-lang/smithy-rs/blob/main/rust-toolchain.toml they require 1.74 and we support 1.72. The latest rustc is 1.76 and we agreed I think to keep MSRV to be 4 versions behind |
datafusion-clidatafusion-cli
Contributor
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
with the latest changes from the main branch and open a new pull request
previous #8681
Closes #.
Rationale for this change
What changes are included in this PR?
Bump datafusion-cli dependencies
use stabilized version aws-sdk 1.x.x (https://www.infoworld.com/article/3711271/aws-delivers-aws-sdk-for-rust.html)
use latest clap version
Are these changes tested?
yes
Are there any user-facing changes?