Skip to content

Use stabalized aws-sdk and clap versions in datafusion-cli#9659

Closed
satyakommula96 wants to merge 3 commits intoapache:mainfrom
satyakommula96:bump_deps
Closed

Use stabalized aws-sdk and clap versions in datafusion-cli#9659
satyakommula96 wants to merge 3 commits intoapache:mainfrom
satyakommula96:bump_deps

Conversation

@satyakommula96
Copy link
Copy Markdown

@satyakommula96 satyakommula96 commented Mar 18, 2024

Which issue does this PR close?

with the latest changes from the main branch and open a new pull request

previous #8681

Closes #.

Rationale for this change

What changes are included in this PR?

Bump datafusion-cli dependencies
use stabilized version aws-sdk 1.x.x (https://www.infoworld.com/article/3711271/aws-delivers-aws-sdk-for-rust.html)
use latest clap version

Are these changes tested?

yes

Are there any user-facing changes?

@satyakommula96
Copy link
Copy Markdown
Author

please review @alamb @comphead

@alamb alamb changed the title bump aws-sdk and clap versions bump aws-sdk and clap versions in datafusion-cli Mar 18, 2024
alamb
alamb previously approved these changes Mar 18, 2024
Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @satyakommula96 -- I also merged up from main to fix a conflict in this PR and to trigger the CI.

@alamb
Copy link
Copy Markdown
Contributor

alamb commented Mar 18, 2024

🤔 CI seems to have failed here: https://github.com/apache/arrow-datafusion/actions/runs/8327813127/job/22786403043?pr=9659

Run cargo msrv verify
Fetching index
Verifying the Minimum Supported Rust Version (MSRV) for toolchain x86_64-unknown-linux-gnu
Using check command cargo check
   Failed check command cargo check didn't succeed
Crate source was found to be incompatible with its MSRV '1.72.1', as defined in '/__w/arrow-datafusion/arrow-datafusion/datafusion-cli/Cargo.toml'
Error: Process completed with exit code 1.

@comphead
Copy link
Copy Markdown
Contributor

comphead commented Mar 18, 2024

ouch, MSRV failed. https://github.com/smithy-lang/smithy-rs/blob/main/rust-toolchain.toml they require 1.74 and we support 1.72.

The latest rustc is 1.76 and we agreed I think to keep MSRV to be 4 versions behind

@alamb alamb changed the title bump aws-sdk and clap versions in datafusion-cli Use stabalized aws-sdk and clap versions in datafusion-cli Mar 18, 2024
@alamb alamb dismissed their stale review March 18, 2024 18:27

MSRV not satisfied

@alamb
Copy link
Copy Markdown
Contributor

alamb commented Mar 18, 2024

Looks like we never formalized the MSRV discussion in #9082 -- I will make a PR to do so now

Update: #9681

@alamb alamb marked this pull request as draft March 18, 2024 21:14
@github-actions
Copy link
Copy Markdown

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions Bot added the Stale PR has not had any activity for some time label May 21, 2024
@github-actions github-actions Bot closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stale PR has not had any activity for some time

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants