Skip to content

[Minor] Update TCPDS tests, remove some #[ignore]d tests #9829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 2 commits into from
Mar 28, 2024
Merged

[Minor] Update TCPDS tests, remove some #[ignore]d tests #9829

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a503f9
Update TCPDS tests
Dandandan Mar 27, 2024
84cd753
Fmt
Dandandan Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions datafusion/core/tests/tpcds_planning.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,6 @@ async fn tpcds_logical_q9() -> Result<()> {
create_logical_plan(9).await
}

#[ignore]
Copy link
Contributor Author

@Dandandan Dandandan Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q41 is the remaining failing logical plan test

// Schema error: No field named 'c'.'c_customer_sk'.
// issue: https://github.com/apache/arrow-datafusion/issues/4794
#[tokio::test]
async fn tpcds_logical_q10() -> Result<()> {
create_logical_plan(10).await
Expand Down Expand Up @@ -201,9 +198,6 @@ async fn tpcds_logical_q34() -> Result<()> {
create_logical_plan(34).await
}

#[ignore]
// Schema error: No field named 'c'.'c_customer_sk'.
// issue: https://github.com/apache/arrow-datafusion/issues/4794
#[tokio::test]
async fn tpcds_logical_q35() -> Result<()> {
create_logical_plan(35).await
Expand Down Expand Up @@ -577,7 +571,7 @@ async fn tpcds_physical_q9() -> Result<()> {
create_physical_plan(9).await
}

#[ignore] // FieldNotFound
#[ignore] // Physical plan does not support logical expression Exists(<subquery>)
#[tokio::test]
async fn tpcds_physical_q10() -> Result<()> {
create_physical_plan(10).await
Expand Down Expand Up @@ -703,7 +697,7 @@ async fn tpcds_physical_q34() -> Result<()> {
create_physical_plan(34).await
}

#[ignore] // FieldNotFound
#[ignore] // Physical plan does not support logical expression Exists(<subquery>)
#[tokio::test]
async fn tpcds_physical_q35() -> Result<()> {
create_physical_plan(35).await
Expand Down Expand Up @@ -734,7 +728,8 @@ async fn tpcds_physical_q40() -> Result<()> {
create_physical_plan(40).await
}

#[ignore] // Physical plan does not support logical expression (<subquery>)
#[ignore]
// Context("check_analyzed_plan", Plan("Correlated column is not allowed in predicate: (..)
#[tokio::test]
async fn tpcds_physical_q41() -> Result<()> {
create_physical_plan(41).await
Expand Down