style changes #573
Merged
style changes #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leerho
approved these changes
Jun 15, 2024
Contributor
leerho
left a comment
leerho
left a comment
There was a problem hiding this comment.
Modern Java styling no longer recommends using a trailing (or leading) "_" character for class member variables. It used to be fairly common years ago but you won't see it in more recent JVM java classes. Most IDEs will emphasize class members with bold or colored text. It is not wrong, but code using this convention tends to look "dated" :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no changes in behavior, style only (indentation, naming)