Fix BinomialBoundsN may divide 0 #708
Merged
+13
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leerho
requested changes
Jan 5, 2026
Member
leerho
left a comment
leerho
left a comment
There was a problem hiding this comment.
Thanks for catching the incomplete check on theta!
src/test/java/org/apache/datasketches/thetacommon/BinomialBoundsNTest.java
Outdated
Show resolved
Hide resolved
ZENOTME
force-pushed
the
fix_binomial_bounds
branch
from
cfff061 to
ad3f061
Compare
tisonkun
approved these changes
Jan 7, 2026
Member
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
Thanks for your contribution! LGTM.
leerho
approved these changes
Jan 7, 2026
Member
leerho
left a comment
leerho
left a comment
There was a problem hiding this comment.
I did not request changes. Not sure where that came from. Nonetheless LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #707