Fixed some checkstyle configuration errors. #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aligned checkstyle config with DS-Java checkstyle config. Fixed some minor issues identified by checkstyle.
jmalkin
reviewed
May 15, 2024
tools/MemoryCheckstyle.xml
Outdated
| <property name="charset" value="UTF-8"/> | ||
| <property name="severity" value="warning"/> | ||
| <property name="fileExtensions" value="java"/> | ||
| <property name="basedir" value="${basedir}"/> |
Contributor
There was a problem hiding this comment.
why is this added? I seem to recall it caused issues with VS Code and we removed it from ds-java.
Contributor
There was a problem hiding this comment.
Please remove this line and we can close out this PR
Member
Author
There was a problem hiding this comment.
Sorry 'bout that. I was trying to figure out how to resolve ${basedir} and it seems that the checkstyle plugin has to be declared in the pom in order for this to happen.
Then I forgot that that property was still in there.
jmalkin
approved these changes
May 17, 2024
jmalkin
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligned checkstyle config with DS-Java checkstyle config.
Fixed some minor issues identified by checkstyle.