Skip to content

Conversation

@leerho
Copy link
Member

@leerho leerho commented Nov 6, 2024

Pull in changes from leerho/datasketches-memory/minor_changes_in_wording:

  1. .github/workflows/manual-coverage.yml
  • update actions from @V3 to @v4. Does not work properly in my personal repo:
    Error: Failed to execute goal org.eluder.coveralls:coveralls-maven-plugin:4.3.0:report (default-cli) on project datasketches-memory:
    Build error: Either repository token or service with job id must be defined -> [Help 1]
  1. .github/workflows/manual-os-matrix.yml
  • update actions from @V3 to @v4.
  1. .github/workflows/manual-share-data.yml
  • update actions from @V3 to @v4
  1. src/test/java/org/apache/datasketches/memory/internal/AllocateDirectMapMemoryTest.java
  • Remove Memory.isLoaded() calls that are incompatible with Windows
  • Remove unnecessary SuppressWarnings("resource")
  1. src/test/java/org/apache/datasketches/memory/internal/AllocateDirectMemoryTest.java
  • Remove some unnecessary SuppressWarnings("resource")
  1. src/test/java/org/apache/datasketches/memory/internal/AllocateDirectWritableMapMemoryTest.java
  • Remove unnecessary SuppressWarnings("resource")
  • Remove Memory.isLoaded() calls that are incompatible with Windows
  1. src/test/java/org/apache/datasketches/memory/internal/BufferTest.java
  • Remove unnecessary SuppressWarnings("resource")
  • Remove unused import
  1. src/test/java/org/apache/datasketches/memory/internal/CopyMemoryTest.java
  • Remove unnecessary SuppressWarnings("resource")
  1. src/test/java/org/apache/datasketches/memory/internal/ExampleMemoryRequestServerTest.java
  • Remove unnecessary SuppressWarnings("resource")
  1. src/test/java/org/apache/datasketches/memory/internal/IgnoredArrayOverflowTest.java
  • Remove unnecessary SuppressWarnings("resource")
  1. src/test/java/org/apache/datasketches/memory/internal/MemoryTest.java
  • Remove unnecessary SuppressWarnings("resource")
  1. src/test/java/org/apache/datasketches/memory/internal/NativeWritableBufferImplTest.java
  • Remove unnecessary SuppressWarnings("resource")
  1. src/test/java/org/apache/datasketches/memory/internal/NativeWritableMemoryImplTest.java
  • Remove unnecessary SuppressWarnings("resource")
  1. src/test/java/org/apache/datasketches/memory/internal/PositionalTest.java
  • Remove unused imports
  • Remove unused static class member
  1. src/test/java/org/apache/datasketches/memory/internal/UtilTest.java # check for extra space
  • Remove unused imports
  • Fix string length from file to work with both Macos/unix and Windows
  1. src/test/java/org/apache/datasketches/memory/internal/WritableMemoryTest.java
  • Remove unused imports
  1. src/test/java/org/apache/datasketches/memory/internal/ZeroCapacityTest.java
  • Remove unnecessary SuppressWarnings("resource")
  1. .toolchains.xml was deleted

@leerho leerho merged commit aa1ed98 into apache:minor_changes_in_wording Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant