Frank grimes java 21 ffm #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The project's minimum Java release requirements moved from Java 17 to Java 21. Package imports changed from `jdk.incubator.foreign` -> `java.lang.foreign` and a number of API changes were required. Notably, the new `java.lang.foreign.Arena` class needs to be exposed when allocating native memory regions as it controls the scope and lifecycle of allocations. Respective API docs are as follows: - https://docs.oracle.com/en/java/javase/17/docs/api/jdk.incubator.foreign/jdk/incubator/foreign/package-summary.html - https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/lang/foreign/package-summary.html
This is to try to address file permission errors seen in some GitHub Action Workflow runs on Windows: "[INFO] Error: Failures: Error: LeafImplTest.checkMapLeafs:118 » AccessDenied TestFile2.bin Error: SpecificLeafTest.checkMapLeafs:108 » AccessDenied TestFile2.bin"
This is to try to address following errors seen in some GitHub Action Workflow runs on Windows: "Warning: Files with unapproved licenses: force_original.txt"
Migrate to Java 21 FFM API
Mostly Checkstyle issues
Had to upgrade my Java 21 JDK to Temurin 21.0.5+11 due to a discovered bug in Java.
README.md
Outdated
| ### *NOTE: The DataSketches Java Memory Component is not thread-safe.* | ||
| ### *NOTES:* | ||
| * The DataSketches Java Memory Component is not thread-safe. | ||
| * I recommend Eclipse Adoptium/Temurin 21.0.5+11 or later as earlier releases of 21 have bugs that affect this product. |
Contributor
There was a problem hiding this comment.
first person recommendation looks strange
| long v = wbuf.getLong(); | ||
| assertEquals(v, i); | ||
| } | ||
| for (int i = 0; i < n; i++) { |
Contributor
There was a problem hiding this comment.
what happened to alignment here and below? tabs used?
Member
Author
There was a problem hiding this comment.
Wow! this is weird. No tabs used. Not sure how this happened. We have had two folks editing these files recently, perhaps they used a different indention scheme.
| wbuf.getLongArray(arr2, 0, n); | ||
| for (int i = 0; i < n; i++) { | ||
| assertEquals(arr2[i], i); | ||
| wbuf.putLongArray(arr, 0, n); |
Contributor
There was a problem hiding this comment.
seems like some problem with alignment all over the place
Member
Author
There was a problem hiding this comment.
This occurred in a bunch of files. I went through all of them and I think it is OK now.
AlexanderSaydakov
approved these changes
Dec 9, 2024
Contributor
AlexanderSaydakov
left a comment
AlexanderSaydakov
left a comment
There was a problem hiding this comment.
I see some formatting problems, but I don't think they should stop this effort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade much of the API that was based on Java 17 to use new Java 21 FFM API, which is in "preview" mode.
Also was able to remove some duplicated code.
Updated POM, as well as the GH Actions workflows.
This PR upgrades the Main branch to Java 21.
Note: I found a bug in Temurin Java 21.0.2 JDK and had to upgrade to Temurin Java 21.0.2+11 release.