Skip to content

Conversation

@zzzxl1993
Copy link
Collaborator

@zzzxl1993 zzzxl1993 commented Aug 22, 2023

  1. Optimize query interface

class AllTopDocsCollector : public HitCollector {
public:
AllTopDocsCollector(const Functor& cb) : cb_(cb) {}
AllTopDocsCollector(const DocRangeFunctor& range_cb) : range_cb_(range_cb) {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be some test code need for new collector

Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants