[Fix] Fixed issue with top level struct column having present stream failing to access repeatedly when late materialization occurs. #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…failing to access repeatedly when deferred materialization occurs.
suxiaogang223
approved these changes
Apr 23, 2025
hubgeter
approved these changes
Apr 23, 2025
kaka11chen
changed the title
morningman
approved these changes
Apr 23, 2025
kaka11chen
added a commit
to kaka11chen/doris-thirdparty
that referenced
this pull request
Apr 29, 2025
…failing to access repeatedly when deferred materialization occurs. (apache#309)
morningman
pushed a commit
to apache/doris
that referenced
this pull request
May 7, 2025
…sent stream failing to access repeatedly when late materialization occurs. (#50358) ### What problem does this PR solve? Related PR: apache/doris-thirdparty#309 apache/doris-thirdparty#310 Problem Summary: When using an older version of pyorc (e.g., pyorc-0.3.0), If there are null values in the data, a present stream will be generated for the top level struct column. However, this behavior does not occur in newer versions of pyorc (e.g., pyorc-0.10.0) or in ORC files generated by tools like Hive or Spark. Therefore, the present stream generated by the older version causes the ORC file to be read twice during late materialization, resulting in an error 'bad read in next buffer' during the second read. The current solution is to avoid reading the present stream if it is in the top level struct column.
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…sent stream failing to access repeatedly when late materialization occurs. (apache#50358) ### What problem does this PR solve? Related PR: apache/doris-thirdparty#309 apache/doris-thirdparty#310 Problem Summary: When using an older version of pyorc (e.g., pyorc-0.3.0), If there are null values in the data, a present stream will be generated for the top level struct column. However, this behavior does not occur in newer versions of pyorc (e.g., pyorc-0.10.0) or in ORC files generated by tools like Hive or Spark. Therefore, the present stream generated by the older version causes the ORC file to be read twice during late materialization, resulting in an error 'bad read in next buffer' during the second read. The current solution is to avoid reading the present stream if it is in the top level struct column.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using an older version of pyorc (e.g., pyorc-0.3.0), If there are null values in the data, a present stream will be generated for the top level struct column.
However, this behavior does not occur in newer versions of pyorc (e.g., pyorc-0.10.0) or in ORC files generated by tools like Hive or Spark.
Therefore, the present stream generated by the older version causes the ORC file to be read twice during late materialization, resulting in an error 'bad read in next buffer' during the second read. The current solution is to avoid reading the present stream if it is in the top level struct column.