Skip to content

An already merged rowset should skip window check #5151

@wangbo

Description

@wangbo

When I upgrade one be from 0.12 to 0.13.11, I found log as below:

W1224 14:33:37.902747 407046 cumulative_compaction.cpp:94] There are missed versions among rowsets. prev rowset verison=[254211-304122], next rowset version=[304141-304141], tablet=1270127.782010313.8f4b94bfeec38b2c-4f09624a4825959a

It seems that rowset [304123-304140] is missed.
But the truth is [304122-304140] is already merged and its create time is updated when merge finished.
So its create time is even later than [304141-304141].

rowset [254211-304122] merge time:

I1224 14:32:55.143887 407047 compaction.cpp:117] succeed to do cumulative compaction. tablet=1270127.782010313.8f4b94bfeec38b2c-4f09624a4825959a, output_version=254211-304122, segments=5. elapsed time=0.054334s.

rowset [304123-304140] merge time:

I1224 14:33:21.115556 407038 compaction.cpp:117] succeed to do cumulative compaction. tablet=1270127.782010313.8f4b94bfeec38b2c-4f09624a4825959a, output_version=304123-304140, segments=3. elapsed time=0.041287

rowset [304141-304141] create time

I1224 14:32:53.966773 407106 engine_publish_version_task.cpp:114] publish version successfully on tablet. tablet=1270127.782010313.8f4b94bfeec38b2c-4f09624a4825959a, transaction_id=21035995, version=304141, res=0

The miss version log is really confusing, I think a already merged rowset shouldn't be checked by config::cumulative_compaction_skip_window_seconds

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions