Skip to content

[Enhancement] Confusing log messages from some if branches when check Status #9513

@platoneko

Description

@platoneko

Search before asking

  • I had searched in the issues and found no similar issues.

Description

Currently, OLAPInternalError will catch the exception stack, however in some cases these stack messages can be confusing:
image
While running the above code, even if the status returned is ok, OLAPInternalError is constructed in if condition, and it will capture the stack info. What's worse, Status::assemble_state() will print a WARNING log, though there is no exception Status:
image

Solution

Check Status::precise_code instead of constructing OLAPInternalError in if condition.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions