[enhancement] Change array offset type from UInt32 to UInt64 #10070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonis0147
reviewed
Jun 14, 2022
be/src/runtime/collection_value.h
Outdated
| // child column data | ||
| void* _data; | ||
| uint32_t _length; | ||
| int64_t _length; |
Contributor
There was a problem hiding this comment.
Using uint64_t is better. For some places which need signed value, we use signed value there.
be/src/runtime/collection_value.h
Outdated
| return false; | ||
| } | ||
| bool seek(uint32_t n) const { | ||
| bool seek(int64_t n) const { |
Contributor
There was a problem hiding this comment.
If using int64_t here, the function seek should check whether n is negative.
Contributor
|
why int64 not uint64？ |
Contributor
Author
|
int64 is already enough, and JAVA do not have uint64. |
cambyzju
changed the title
github-actions
bot
added
the
area/sql/function
HappenLee
reviewed
Jun 16, 2022
| // vectorized this code to speed up | ||
| IColumn::Offset counts[size]; | ||
| for (size_t i = 0; i < size; ++i) { | ||
| for (ssize_t i = 0; i < size; ++i) { |
Contributor
There was a problem hiding this comment.
size is size_t, not need change i to sszie_t
Contributor
Author
There was a problem hiding this comment.
We use offsets[i - 1] inside this for loop, so it is better to use ssize_t for index -1.
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #7570
Problem Summary:
Now column
Array<T>contains columnoffsetsanddata, and type of columnoffsetsis UInt32 now.If we call array_union to merge arrays repeatedly, the size of array may overflow.
So we need to extend it before
Array Data Typerelease.Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...