Skip to content

[Bug][Vectorized] Fix DCHECK failed in VExchangeNode close twice #10184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HappenLee merged 1 commit into from
Jun 16, 2022
Merged

[Bug][Vectorized] Fix DCHECK failed in VExchangeNode close twice #10184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion be/src/vec/exec/vexchange_node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,13 @@ Status VExchangeNode::get_next(RuntimeState* state, Block* block, bool* eos) {
}

Status VExchangeNode::close(RuntimeState* state) {
if (is_closed()) {
return Status::OK();
}

if (_stream_recvr != nullptr) {
_stream_recvr->close();
}

if (_is_merging) _vsort_exec_exprs.close(state);

return ExecNode::close(state);
Expand Down
1 change: 1 addition & 0 deletions be/src/vec/exec/vunion_node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ Status VUnionNode::get_next(RuntimeState* state, Block* block, bool* eos) {
RETURN_IF_CANCELLED(state);
// RETURN_IF_ERROR(QueryMaintenance(state));

// TODO: Rethink the logic, which cause close the exec node twice.
if (_to_close_child_idx != -1) {
// The previous child needs to be closed if passthrough was enabled for it. In the non
// passthrough case, the child was already closed in the previous call to get_next().
Expand Down