Skip to content

Conversation

@stalary
Copy link
Contributor

@stalary stalary commented Jun 21, 2022

Proposed changes

Issue Number: close #10203

Problem Summary:

Describe the overview of changes.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@stalary
Copy link
Contributor Author

stalary commented Jun 22, 2022

I found that this did not solve the superset presentation problem and that the change affected many UT and Regression, so I close it.

@stalary stalary closed this Jun 22, 2022
@stalary stalary reopened this Jun 24, 2022
@stalary
Copy link
Contributor Author

stalary commented Jun 24, 2022

Superset and dathub use sqlalchemy by show create table sql get metadata,Standard mysql syntax, comment uses single quotes. The changes in this PR can resolve the comment issue at the column level.

morningman
morningman previously approved these changes Jun 30, 2022
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 30, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jun 30, 2022
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022

PR approved by at least one committer and no changes requested.

@morningman morningman merged commit d43d3fc into apache:master Jul 1, 2022
@stalary stalary deleted the compat_comment branch July 17, 2022 07:35
@morningman morningman mentioned this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Show create table Comment use single quotes

3 participants