[Bug](MaterializedView) Fix bug of light schema change do not set right unique id cause MV coredump #11396
Conversation
github-actions
bot
added
the
area/planner
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
| Preconditions.checkNotNull(defineExpr != null); | ||
| Column result = new Column(name, type, isKey, aggregationType, ColumnDef.DefaultValue.ZERO, ""); | ||
| result.setDefineExpr(defineExpr); | ||
| result.setUniqueId(olapTable.incAndGetMaxColUniqueId()); |
There was a problem hiding this comment.
In the future, this change will cause problem when we want to support mv do light schema change and olapTable.incAndGetMaxColUniqueId() need to write editlog for duration.
the commit can justly use temporaryly.
There was a problem hiding this comment.
could you try like this in MaterializedViewHandler.java checkAndPrepareMaterializedView()
for (Column column : rollupSchema) {
column.setUniqueId(Column.COLUMN_UNIQUE_ID_INIT_VALUE);
}
There was a problem hiding this comment.
could you try like this in MaterializedViewHandler.java checkAndPrepareMaterializedView()
for (Column column : rollupSchema) { column.setUniqueId(Column.COLUMN_UNIQUE_ID_INIT_VALUE); }
Hi, Do you can review #10792? I set uniqid also.
There was a problem hiding this comment.
@ the change will override yours
could you try like this in MaterializedViewHandler.java checkAndPrepareMaterializedView()
for (Column column : rollupSchema) { column.setUniqueId(Column.COLUMN_UNIQUE_ID_INIT_VALUE); }Hi, Do you can review #10792? I set uniqid also.
the change will override yours
HappenLee
changed the title
github-actions
bot
removed
the
approved
| defaultDb = "regression_test" | ||
|
|
||
| jdbcUrl = "jdbc:mysql://127.0.0.1:9030/?" | ||
| jdbcUrl = "jdbc:mysql://127.0.0.1:9031/?" |
4 participants
Proposed changes
Issue Number: close #11334
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...