[feature](cold_on_s3) Show remote data usage via SHOW BACKENDS and SHOW TABLETS statements #11450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stalary
reviewed
Aug 4, 2022
| .add("TabletId").add("ReplicaId").add("BackendId").add("SchemaHash").add("Version") | ||
| .add("LstSuccessVersion").add("LstFailedVersion").add("LstFailedTime") | ||
| .add("DataSize").add("RowCount").add("State") | ||
| .add("LocalDataSize").add("RemoteDataSize").add("RowCount").add("State") |
Contributor
There was a problem hiding this comment.
This would cause compatibility problems, would using DataSize also work?
Contributor
Author
There was a problem hiding this comment.
Of course we can use DataSize here, but I think it may be a little confusing when users find DataSize is 0.
platoneko
force-pushed
the
show_remote_data_size
branch
4 times, most recently
from
16f81b5 to
f4a8caf
Compare
platoneko
changed the title
platoneko
force-pushed
the
show_remote_data_size
branch
from
f4a8caf to
1481631
Compare
platoneko
changed the title
platoneko
force-pushed
the
show_remote_data_size
branch
from
1481631 to
82e2c5d
Compare
morningman
reviewed
Aug 20, 2022
| auto key = get_key(path); | ||
| auto fs_path = Path(_s3_conf.endpoint) / _s3_conf.bucket / key; | ||
| *reader = std::make_unique<S3FileReader>(std::move(fs_path), fsize, std::move(key), | ||
| *reader = std::make_shared<S3FileReader>(std::move(fs_path), fsize, std::move(key), |
Contributor
Author
There was a problem hiding this comment.
This is a typo(not bug) fix, as function signature is S3FileSystem::open_file(const Path& path, FileReaderSPtr* reader)
| .add("SystemDecommissioned").add("ClusterDecommissioned").add("TabletNum") | ||
| .add("DataUsedCapacity").add("AvailCapacity").add("TotalCapacity").add("UsedPct") | ||
| .add("MaxDiskUsedPct").add("Tag").add("ErrMsg").add("Version").add("Status") | ||
| .add("MaxDiskUsedPct").add("Tag").add("ErrMsg").add("Version").add("Status").add("RemoteUsedCapacity") |
Contributor
There was a problem hiding this comment.
Better to add RemoteUsedCapacity right after DataUsedCapacity
Contributor
Author
There was a problem hiding this comment.
Some unit tests and regression tests rely on the subscript of these data. If RemoteUsedCapacity is inserted into the middle, the tests will fail.
| public static final ImmutableList<String> TITLE_NAMES = new ImmutableList.Builder<String>().add("ReplicaId") | ||
| .add("BackendId").add("Version").add("LstSuccessVersion").add("LstFailedVersion").add("LstFailedTime") | ||
| .add("SchemaHash").add("LocalDataSize").add("RowCount").add("State").add("IsBad") | ||
| .add("VersionCount").add("PathHash").add("MetaUrl").add("CompactionStatus").add("RemoteDataSize").build(); |
Contributor
There was a problem hiding this comment.
Add RemoteDataSize right after LocalDataSize.
| .add("LocalDataSize").add("RowCount").add("State") | ||
| .add("LstConsistencyCheckTime").add("CheckVersion") | ||
| .add("VersionCount").add("PathHash").add("MetaUrl").add("CompactionStatus") | ||
| .add("VersionCount").add("PathHash").add("MetaUrl").add("CompactionStatus").add("RemoteDataSize") |
morningman
added
the
kind/api-change
platoneko
force-pushed
the
show_remote_data_size
branch
from
82e2c5d to
97f7d09
Compare
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
platoneko
force-pushed
the
show_remote_data_size
branch
from
97f7d09 to
dd01403
Compare
github-actions
bot
removed
the
approved
platoneko
force-pushed
the
show_remote_data_size
branch
from
dd01403 to
8d673db
Compare
morningman
approved these changes
Aug 25, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...