Skip to content

Conversation

@hello-stephen
Copy link
Contributor

@hello-stephen hello-stephen commented Aug 5, 2022

Proposed changes

Issue Number: close #xxx

Problem summary

At current, I don't find a convenient way to show FE's build info, so I try to add it.

start_fe.sh --version will output info like:

...
Build version: trunk
Build time: Fri, 05 Aug 2022 15:14:34 CST
Build info: lidongyang@rd-dev-hk-ali02
Build hash: git://rd-dev-hk-ali02/mnt/disk1/stephen/doris@e088c1adfec463e439f90c336bd32c479a69bfce
Java compile version: java full version "1.8.0_341-b10"

by the way, ./doris_be -v will output this:

trunk RELEASE (build git://rd-dev-hk-ali02/mnt/disk1/stephen/doris/be/../@e088c1adfec463e439f90c336bd32c479a69bfce)
Built on Fri, 05 Aug 2022 15:11:17 CST by lidongyang@rd-dev-hk-ali02

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@hello-stephen hello-stephen changed the title [script](start_fe) support "--version" to show fe build info [script](start_fe)'start_fe.sh --version' to show fe build info Aug 5, 2022
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 6c065d3 into apache:master Aug 8, 2022
@hello-stephen hello-stephen deleted the fe-version branch September 1, 2022 10:16
@morningman morningman mentioned this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants