Skip to content

Conversation

@Gabriel39
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@Gabriel39 Gabriel39 force-pushed the add_disable_auto_compact branch from bb58b43 to a04bd24 Compare August 12, 2022 11:27
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to document

@github-actions github-actions bot added the kind/docs Categorizes issue or PR as related to documentation. label Aug 14, 2022
@Gabriel39 Gabriel39 requested a review from morningman August 14, 2022 07:04
@Gabriel39 Gabriel39 force-pushed the add_disable_auto_compact branch 3 times, most recently from 283186a to 21a2e8d Compare August 16, 2022 10:44
@Gabriel39 Gabriel39 force-pushed the add_disable_auto_compact branch from 21a2e8d to e9d42e6 Compare August 16, 2022 10:55
@Gabriel39 Gabriel39 requested a review from yiguolei August 16, 2022 12:54
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit ba3e0b3 into apache:master Aug 17, 2022
@morningman morningman mentioned this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/docs Categorizes issue or PR as related to documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants