-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Improvement](load) turn enable_vectorized_load on by default
#11833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
51cf4d3 to
0e871d6
Compare
stalary
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0e871d6 to
4d5fe27
Compare
9d03c17 to
bf9f25a
Compare
be/src/vec/core/block.cpp
Outdated
| for (auto& d : data) { | ||
| DCHECK(d.column->use_count() == 1); | ||
| if (UNLIKELY(d.column->use_count() != 1)) { | ||
| LOG(INFO) << "Ref count of column is " << d.column->use_count(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe change to LOG(WARNING)
spaces-X
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
Proposed changes
Issue Number: close #11832 #11841 #10666
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...