Skip to content

Conversation

@Gabriel39
Copy link
Contributor

@Gabriel39 Gabriel39 commented Aug 16, 2022

Proposed changes

Issue Number: close #11832 #11841 #10666

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@Gabriel39 Gabriel39 force-pushed the turn_on_vectorized_load branch from 51cf4d3 to 0e871d6 Compare August 17, 2022 08:03
stalary
stalary previously approved these changes Aug 17, 2022
Copy link
Contributor

@stalary stalary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabriel39 Gabriel39 force-pushed the turn_on_vectorized_load branch from 9d03c17 to bf9f25a Compare August 18, 2022 03:25
for (auto& d : data) {
DCHECK(d.column->use_count() == 1);
if (UNLIKELY(d.column->use_count() != 1)) {
LOG(INFO) << "Ref count of column is " << d.column->use_count();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe change to LOG(WARNING)

Copy link
Contributor

@spaces-X spaces-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 18, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit b8a33d2 into apache:master Aug 18, 2022
@morningman morningman mentioned this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/vectorization reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] turn enable_vectorized_load on by default

5 participants