Fix bug that restore process in BE causes BE crash #1193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling SnapshotLoader.move(), all files should be revoked if they are in GC queue, or the file may be deleted after move() success.
imay
requested changes
May 23, 2019
be/src/runtime/snapshot_loader.cpp
Outdated
| for (auto& snapshot_file : snapshot_files) { | ||
| if (std::find(tablet_files.begin(), tablet_files.end(), snapshot_file) != tablet_files.end()) { | ||
| std::string file_path = tablet_path + "/" + snapshot_file; | ||
| files_to_check.push_back(file_path); |
Contributor
There was a problem hiding this comment.
Suggested change
| files_to_check.push_back(file_path); | |
| files_to_check.emplace_back(std::move(file_path)); |
| std::string full_dest_path = tablet_path + "/" + file; | ||
| RETURN_IF_ERROR(FileUtils::copy_file(full_src_path, full_dest_path)); | ||
| VLOG(2) << "copy file from " << full_src_path<< " to " << full_dest_path; | ||
| if (link(full_src_path.c_str(), full_dest_path.c_str()) != 0) { |
Contributor
There was a problem hiding this comment.
if this function return failed, who will clean the already linked files
get the error msg for link error
morningman
force-pushed
the
restore_delete_file_bug
branch
from
fb4780b to
fe37e6a
Compare
imay
approved these changes
May 23, 2019
luwei16
pushed a commit
to luwei16/Doris
that referenced
this pull request
Apr 7, 2023
…add gc (apache#1191) (apache#1193) * [improvement](memory) simplify memory config related to tcmalloc There are several configs related to tcmalloc, users do know how to config them. Actually users just want two modes, performance or compact, in performance mode, users want doris run query and load quickly while in compact mode, users want doris run with less memory usage. If we want to config tcmalloc individually, we can use env variables which are supported by tcmalloc. * [improvement](tcmalloc) add moderate mode and avoid oom with a lot of cache (apache#14374) ReleaseToSystem aggressively when there are little free memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling SnapshotLoader.move(), all files should be revoked if they
are in GC queue, or the file may be deleted after move() success.
ISSUE #1191