Skip to content

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Aug 24, 2022

Proposed changes

Issue Number: close #xxx

Problem summary

  1. Copy most of profiles from VOlapScanNode and VOlapScanner to NewOlapScanNode and NewOlapScanner.
  2. Fix some blocking bug of new scan framework.

TODO:

  1. Memtracker
  2. Opentelemetry spen

The new framework is still disabled by default, so it will not effect other feature.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningman morningman marked this pull request as draft August 24, 2022 08:40
@morningman morningman force-pushed the new_olap_node_profile branch from 365980c to f57dc5c Compare August 26, 2022 08:50
@morningman morningman marked this pull request as ready for review August 29, 2022 13:13
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit a16cf0e into apache:master Aug 30, 2022
morningman added a commit to morningman/doris that referenced this pull request Aug 30, 2022
Jibing-Li pushed a commit to Jibing-Li/incubator-doris that referenced this pull request Aug 30, 2022
Copy most of profiles from VOlapScanNode and VOlapScanner to NewOlapScanNode and NewOlapScanner.
Fix some blocking bug of new scan framework.
TODO:

Memtracker
Opentelemetry spen
The new framework is still disabled by default, so it will not effect other feature.
xinyiZzz pushed a commit to xinyiZzz/incubator-doris that referenced this pull request Aug 30, 2022
Copy most of profiles from VOlapScanNode and VOlapScanner to NewOlapScanNode and NewOlapScanner.
Fix some blocking bug of new scan framework.
TODO:

Memtracker
Opentelemetry spen
The new framework is still disabled by default, so it will not effect other feature.
GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Aug 31, 2022
Copy most of profiles from VOlapScanNode and VOlapScanner to NewOlapScanNode and NewOlapScanner.
Fix some blocking bug of new scan framework.
TODO:

Memtracker
Opentelemetry spen
The new framework is still disabled by default, so it will not effect other feature.
Yukang-Lian pushed a commit to Yukang-Lian/doris that referenced this pull request Sep 2, 2022
Copy most of profiles from VOlapScanNode and VOlapScanner to NewOlapScanNode and NewOlapScanner.
Fix some blocking bug of new scan framework.
TODO:

Memtracker
Opentelemetry spen
The new framework is still disabled by default, so it will not effect other feature.
Yukang-Lian pushed a commit to Yukang-Lian/doris that referenced this pull request Sep 2, 2022
Copy most of profiles from VOlapScanNode and VOlapScanner to NewOlapScanNode and NewOlapScanner.
Fix some blocking bug of new scan framework.
TODO:

Memtracker
Opentelemetry spen
The new framework is still disabled by default, so it will not effect other feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants