[refactor](planner)Cancel the return value default 65535 limit #12478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/planner
morningman
reviewed
Nov 18, 2022
| newDefaultOrderByLimit = 65535; | ||
| if (analyzer.getContext().getSessionVariable().defaultOrderByLimit <= -1) { | ||
| newDefaultOrderByLimit = Long.MAX_VALUE; | ||
| LOG.warn("The current default Order By Limit number is the maximum value of Long."); |
| LOG.warn("The current default Order By Limit number is the maximum value of Long."); | ||
| } else { | ||
| newDefaultOrderByLimit = analyzer.getContext().getSessionVariable().defaultOrderByLimit; | ||
| LOG.warn("The current default Order By Limit number is {}." + newDefaultOrderByLimit); |
| newDefaultOrderByLimit = Long.MAX_VALUE; | ||
| LOG.warn("The current default Order By Limit number is the maximum value of Long."); | ||
| } else { | ||
| newDefaultOrderByLimit = analyzer.getContext().getSessionVariable().defaultOrderByLimit; |
Contributor
There was a problem hiding this comment.
you can just call analyzer.getContext().getSessionVariable().defaultOrderByLimit once
|
|
||
| // Default Order By Limit | ||
| @VariableMgr.VarAttr(name = DEFAULT_ORDER_BY_LIMIT) | ||
| public long defaultOrderByLimit = -1; |
Signed-off-by: Yijia Su <suyijia@selectdb.com>
FreeOnePlus
force-pushed
the
default-limit
branch
from
13f568d to
3d70ebd
Compare
github-actions
bot
added
the
kind/docs
Contributor
|
TeamCity pipeline, clickbench performance test result: |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
FreeOnePlus
added a commit
to FreeOnePlus/doris
that referenced
this pull request
Nov 27, 2022
…12478) Originally, Order By Limit returned a maximum of 65535 rows of data by default during the query, but now many businesses do not apply this limit. It is necessary to add larger data after the query statement to complete the full data query, which is extremely inconvenient, so adjustments have been made. At the same time, I added the variable DEFAULT_ORDER_BY_LIMIT to the SessionVariable, the default value is -1, if the user does not use the LIMIT keyword or the LIMIT value is a negative integer, the default query return value is Long.MAX_VALUE. If the corresponding maximum query value is set, the number of data items is returned according to the maximum query value or the value followed by the LIMIT keyword.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Originally, Order By Limit returned a maximum of 65535 rows of data by default during the query, but now many businesses do not apply this limit. It is necessary to add larger data after the query statement to complete the full data query, which is extremely inconvenient, so adjustments have been made.
At the same time, I added the variable DEFAULT_ORDER_BY_LIMIT to the SessionVariable, the default value is -1, if the user does not use the LIMIT keyword or the LIMIT value is a negative integer, the default query return value is Long.MAX_VALUE. If the corresponding maximum query value is set, the number of data items is returned according to the maximum query value or the value followed by the LIMIT keyword.
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...