Skip to content

[Bug](lead) fix wrong child expression of lead function #12587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 2 commits into from
Sep 15, 2022
Merged

[Bug](lead) fix wrong child expression of lead function #12587

yiguolei merged 2 commits into from
Sep 15, 2022

Conversation

@Gabriel39
Copy link
Contributor

@Gabriel39 Gabriel39 commented Sep 14, 2022

Proposed changes

Issue Number: close #12585

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/planner Issues or PRs related to the query planner kind/test labels Sep 14, 2022
HappenLee
HappenLee approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2022

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 14, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2022

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit beeb0ef into apache:master Sep 15, 2022
yiguolei pushed a commit that referenced this pull request Sep 16, 2022
@Gabriel39 @Doris-Extras
[Bug](lead) fix wrong child expression of lead function (#12587)
065745b
yiguolei pushed a commit to yiguolei/incubator-doris that referenced this pull request Sep 16, 2022
@Doris-Extras
Revert "[Bug](lead) fix wrong child expression of lead function (ap…
6605191 
…ache#12587)"

This reverts commit 065745b.
@Gabriel39 Gabriel39 mentioned this pull request Sep 17, 2022
Merged
13 tasks
@yiguolei yiguolei mentioned this pull request Oct 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner dev/merged-1.1.3-deprecated kind/test reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] wrong child expression of lead function

3 participants

@Gabriel39 @HappenLee @yiguolei