Skip to content

[Enhancement](runtime filter)optimize for runtime filter #12856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BiteTheDDDDt merged 4 commits into from
Oct 9, 2022
Merged

[Enhancement](runtime filter)optimize for runtime filter #12856

BiteTheDDDDt merged 4 commits into from
Oct 9, 2022

Conversation

@BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Sep 22, 2022 •
edited
Loading

Proposed changes

  1. optimize build runtime filter.
  2. change hash function of some numeric type in bloom filter.
TPCH-SF100 Before After
q1 11850.0 11756.0
q2 604.8 430.2
q3 3726.4 3195.6
q4 1569.8 1185.0
q5 2875.6 2492.8
q6 971.6 982.8
q7 1439.0 1281.4
q8 1481.8 1085.2
q9 20764.0 20939.0
q10 2113.2 1895.8
q11 615.2 617.8
q12 887.6 749.6
q13 3658.2 3562.4
q14 705.4 653.6
q15 612.8 605.8
q16 910.2 878.6
q17 4969.4 1527.2
q18 4027.2 3957.6
q19 429.4 445.8
q20 1685.0 1574.6
q21 4800.4 4551.6
q22 1261.4 1134.8
SUM 71958.4 65503.2

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@BiteTheDDDDt BiteTheDDDDt force-pushed the opt_0922 branch 3 times, most recently from 97caae5 to be73a66 Compare September 28, 2022 12:51
HappenLee
HappenLee previously approved these changes Oct 8, 2022
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BiteTheDDDDt
optimize for runtime filter
29114ae 
update

update

update

update

fix

update

update

update

update

update

remove datev2

update
HappenLee
HappenLee approved these changes Oct 9, 2022
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2022

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2022

PR approved by anyone and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit 245490d into apache:master Oct 9, 2022
@BiteTheDDDDt BiteTheDDDDt mentioned this pull request Oct 10, 2022
Merged
13 tasks
@BiteTheDDDDt BiteTheDDDDt deleted the opt_0922 branch January 20, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. area/vectorization reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BiteTheDDDDt @HappenLee