[function](hash) add support of murmur_hash3_64 #12923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/sql/function
jacktengg
force-pushed
the
murmur-hash-64
branch
2 times, most recently
from
f53339b to
e305681
Compare
jacktengg
force-pushed
the
murmur-hash-64
branch
2 times, most recently
from
b58e971 to
ecac181
Compare
Also delete duplicated code for murmur_hash3_32
jacktengg
force-pushed
the
murmur-hash-64
branch
from
ecac181 to
8ce55c0
Compare
yiguolei
reviewed
Sep 26, 2022
| } | ||
|
|
||
| // modify from https://github.com/aappleby/smhasher/blob/master/src/MurmurHash3.cpp | ||
| static uint32_t murmur_hash3_32(const void* key, int32_t len, uint32_t seed) { |
Contributor
There was a problem hiding this comment.
Check the comment: modify from https://github.com/aappleby/smhasher/blob/master/src/MurmurHash3.cpp
Why modify the origin code in the past? Is the modified method the same as murmur_hash3_x86_32?
Contributor
Author
There was a problem hiding this comment.
The modified method is the same as murmur_hash3_x86_32, just different in returning value.
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
jacktengg
added a commit
to jacktengg/incubator-doris
that referenced
this pull request
Nov 28, 2022
13 tasks
yiguolei
pushed a commit
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also delete duplicated code for murmur_hash3_32
Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...