[bugfix](compaction) bug: compaction read delete data as normal data #13025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiguolei
reviewed
Sep 28, 2022
| return OLAP_SUCCESS; | ||
| } | ||
| OLAPStatus ret = OLAP_SUCCESS; | ||
| if (read_params.runtime_state && !read_params.runtime_state->skip_delete_predicate()) { |
Contributor
There was a problem hiding this comment.
if (!read_params.runtime_state || !read_params.runtime_state->skip_delete_predicate())
jacktengg
added a commit
to jacktengg/incubator-doris
that referenced
this pull request
Sep 28, 2022
…al data (apache#13025)" This reverts commit 98f1124.
dataroaring
pushed a commit
that referenced
this pull request
Sep 28, 2022
* Revert "[bugfix](compaction) bug: compaction read delete data as normal data (#13025)" This reverts commit 98f1124. * Revert "[improvement](storage) For debugging problems: add session variable skip_storage_engine_merge to treat agg and unique data model as dup model #12973" This reverts commit 7b0313d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...