[refractor](vectorized) refractor some insert_xxx functions #13088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
yiguolei
reviewed
Oct 1, 2022
| T* res_val_ptr = (T*)data.get_end_ptr(); | ||
| memcpy(res_val_ptr, data_ptr, num * sizeof(T)); | ||
| res_val_ptr += num; | ||
| data.set_end_ptr(res_val_ptr); |
Contributor
There was a problem hiding this comment.
If not change end ptr, then the podarray's data size is not changed? Is it wrong?
Contributor
Author
There was a problem hiding this comment.
data.resize(old_size + num); will alloc memory and change end ptr.
Merged
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
As mentioned in #13074, there will be some problem in
ColumnVector<int>::insert_many_in_copy_way.Column::insert_xxx functions will append some data, they should
reserveorresizebefore append data.Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...