Skip to content

Check version hash when full clone #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chaoyli merged 2 commits into from
Jun 19, 2019
Merged

Check version hash when full clone #1331

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0534b8b
Check version hash when full clone
yiguolei Jun 19, 2019
09e8821
Check version hash when full clone
yiguolei Jun 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions be/src/olap/task/engine_clone_task.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,9 @@ OLAPStatus EngineCloneTask::execute() {
bool allow_incremental_clone = false;
// check if current tablet has version == 2 and version hash == 0
// version 2 may be an invalid rowset
Version version_2 = {2, 2};
RowsetSharedPtr rowset_version2 = tablet->get_rowset_by_version(version_2);
if (rowset_version2 == nullptr || rowset_version2->version_hash() != 0) {
Version clone_version = {_clone_req.committed_version, _clone_req.committed_version};
RowsetSharedPtr clone_rowset = tablet->get_rowset_by_version(clone_version);
if (clone_rowset == nullptr || clone_rowset->version_hash() == _clone_req.committed_version_hash) {
// try to incremental clone
vector<Version> missed_versions;
tablet->calc_missed_versions(_clone_req.committed_version, &missed_versions);
Expand All @@ -102,7 +102,10 @@ OLAPStatus EngineCloneTask::execute() {
&allow_incremental_clone,
tablet);
} else {
LOG(INFO) << "current tablet has invalid rowset with version == 2 and version_hash == 0, try to full clone"
LOG(INFO) << "current tablet has invalid rowset that's version == commit_version but version hash not equal"
<< " clone req commit_version=" << _clone_req.committed_version
<< " clone req commit_version_hash=" << _clone_req.committed_version_hash
<< " cur rowset version=" << clone_rowset->version_hash()
<< " tablet info = " << tablet->full_name();
}
if (status == DORIS_SUCCESS && allow_incremental_clone) {
Expand Down