Be refactor optimize meta tool new #1337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaoyli
requested changes
Jun 19, 2019
be/src/tools/meta_tool.cpp
Outdated
| root_path = path_prefix + root_path_postfix; | ||
| void load_meta(DataDir *data_dir) { | ||
| // load json tablet meta into meta | ||
| OLAPStatus s = TabletMetaManager::load_json_header(data_dir, FLAGS_json_meta_path); |
be/src/tools/meta_tool.cpp
Outdated
| } | ||
| void get_meta(DataDir *data_dir) { | ||
| std::string value; | ||
| OLAPStatus s = TabletMetaManager::get_json_header(data_dir, FLAGS_tablet_id, FLAGS_schema_hash, &value); |
be/src/tools/meta_tool.cpp
Outdated
| doris::TabletMetaPB tablet_meta_pb; | ||
| tablet_meta.to_meta_pb(&tablet_meta_pb); | ||
| json2pb::ProtoMessageToJson(tablet_meta_pb, &json_meta, json_options); | ||
| std::cout << "tablet meta:" << std::endl; |
Contributor
There was a problem hiding this comment.
this line is not necessary.
be/src/olap/tablet_meta_manager.cpp
Outdated
| tablet_meta_pb.SerializeToString(&meta_binary); | ||
| TTabletId tablet_id = tablet_meta_pb.tablet_id(); | ||
| TSchemaHash schema_hash = tablet_meta_pb.schema_hash(); | ||
| std::cout << "start to save meta" << std::endl; |
|
|
||
| int main(int argc, char** argv) { | ||
| google::ParseCommandLineFlags(&argc, &argv, true); | ||
| void show_meta() { |
Contributor
There was a problem hiding this comment.
what case need show_meta?
It seems that hdr exist?
be/src/tools/meta_tool.cpp
Outdated
| std::cout << "./meta_tool --operation=delete_header --tablet_id=tabletid --schema_hash=schemahash" << std::endl; | ||
| std::cout << "./meta_tool --root_path=rootpath --operation=rollback" << std::endl; | ||
| std::cout << "./meta_tool --operation=show_header --pb_header_path=path" << std::endl; | ||
| std::string get_usage(std::string progname) { |
chaoyli
approved these changes
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.