Skip to content

[improvement](compaction) delete num based compaction policy #13409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Gabriel39 merged 1 commit into from
Oct 18, 2022
Merged

[improvement](compaction) delete num based compaction policy #13409

Gabriel39 merged 1 commit into from
Oct 18, 2022

Conversation

@yixiutt
Copy link
Contributor

@yixiutt yixiutt commented Oct 17, 2022

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the kind/docs Categorizes issue or PR as related to documentation. label Oct 17, 2022
@yixiutt yixiutt force-pushed the delete_size_based_compaction branch 3 times, most recently from 0c30f5e to 9f7e54a Compare October 17, 2022 09:08
Gabriel39
Gabriel39 previously approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yixiutt yixiutt force-pushed the delete_size_based_compaction branch from 9f7e54a to 5cbf3bc Compare October 17, 2022 10:29
@yixiutt yixiutt force-pushed the delete_size_based_compaction branch from 5cbf3bc to 54f67d1 Compare October 17, 2022 11:53
zhannngchen
zhannngchen approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2022

PR approved by anyone and no changes requested.

Gabriel39
Gabriel39 approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabriel39 Gabriel39 merged commit 6d322f8 into apache:master Oct 18, 2022
platoneko added a commit to platoneko/doris that referenced this pull request Oct 27, 2022
@platoneko
[feature](selectdb-cloud) Pick "delete num based compaction policy (a…
2a8b86c 
…pache#13409)" from doris master (apache#893)

[improvement](compaction) delete num based compaction policy (apache#13409)
Co-authored-by: yixiutt <yixiu@selectdb.com>
@morningman morningman mentioned this pull request Nov 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gabriel39 Gabriel39 Gabriel39 approved these changes

@zhannngchen zhannngchen zhannngchen approved these changes

Assignees

No one assigned

Labels

kind/docs Categorizes issue or PR as related to documentation. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yixiutt @Gabriel39 @zhannngchen