Skip to content

[Improvement](Audit): Remove default_cluster for audit log db #13499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Oct 24, 2022
Merged

[Improvement](Audit): Remove default_cluster for audit log db #13499

yiguolei merged 1 commit into from
Oct 24, 2022

Conversation

@stalary
Copy link
Contributor

@stalary stalary commented Oct 20, 2022 •
edited
Loading

Proposed changes

Issue Number: close #xxx

Problem summary

Remove default_cluster for audit log db equal to user logic.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@stalary stalary added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Oct 20, 2022
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 20, 2022

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 40.57 seconds
load time: 689 seconds
storage size: 17154823374 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221020145511_clickbench_pr_31821.html

morningman
morningman approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 24, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2022

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2022

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit e53baee into apache:master Oct 24, 2022
@stalary stalary deleted the mod/audit_db branch November 11, 2022 00:47
@morningman morningman mentioned this pull request Nov 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stalary @hello-stephen @morningman @yiguolei