Skip to content

Conversation

@dataroaring
Copy link
Contributor

…nd remove disable_stream_load_2pc

Users do not need to set create_table_timeout, it is a ddl command and when encounter a timeout event users will set a lager timeout and retry.

Stream load 2pc is used by default in flink connector, so we should not disable it by config, the config item is useless.

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

…nd remove disable_stream_load_2pc

Users do not need to set create_table_timeout, it is a ddl command and when encounter a timeout event
users will set a lager timeout and retry.

Stream load 2pc is used by default in flink connector, so we should not disable it by config, the config
item is useless.
@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 41.69 seconds
load time: 605 seconds
storage size: 17154768674 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221020174205_clickbench_pr_32129.html

@morningman morningman added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API area/config Issues or PRs related to configuration labels Oct 23, 2022
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 23, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 54545c6 into apache:master Oct 24, 2022
@morningman morningman mentioned this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/config Issues or PRs related to configuration kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants