Skip to content

[Revert](mem) revert the mem config cause perfermace degradation #13526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 2 commits into from
Oct 21, 2022
Merged

[Revert](mem) revert the mem config cause perfermace degradation #13526

yiguolei merged 2 commits into from
Oct 21, 2022

Conversation

@HappenLee
Copy link
Contributor

@HappenLee HappenLee commented Oct 20, 2022

Proposed changes

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Gabriel39
Gabriel39 approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xinyiZzz
Copy link
Contributor

xinyiZzz commented Oct 20, 2022

Related: #13285

@xinyiZzz
Copy link
Contributor

xinyiZzz commented Oct 20, 2022 •
edited
Loading

Is there a brief performance test result? It would be best to have separate tests for page cache, chunk allocator, and pod array~

@github-actions github-actions bot added area/vectorization approved Indicates a PR has been approved by one committer. labels Oct 20, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2022

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2022

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 20, 2022

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 39.14 seconds
load time: 583 seconds
storage size: 17154562463 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221021024211_clickbench_pr_32189.html

@yiguolei yiguolei changed the title [Revert] (mem) revert the mem config cause perfermace degradation [Revert](mem) revert the mem config cause perfermace degradation Oct 21, 2022
@yiguolei yiguolei merged commit d2be509 into apache:master Oct 21, 2022
dataroaring pushed a commit that referenced this pull request Oct 21, 2022
@HappenLee @dataroaring
[Revert](mem) revert the mem config cause perfermace degradation (#13526
dcc8d57 
)

* Revert "[fix](mem) failure of allocating memory (#13414)"

This reverts commit 971eb91.

* Revert "[improvement](memory) disable page cache and chunk allocator, optimize memory allocate size (#13285)"

This reverts commit a5f3880.
Conflicts:
	be/src/common/config.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gabriel39 Gabriel39 Gabriel39 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. area/vectorization reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@HappenLee @xinyiZzz @hello-stephen @Gabriel39 @yiguolei